Conversation
Member
Author
|
@ofborg test xfce |
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
Rebuilt my laptop to f94262a with
|
romildo
previously approved these changes
Mar 29, 2023
Contributor
|
Result of 1 package marked as broken and skipped:
3 packages failed to build:
88 packages built:
|
Member
Author
Member
Author
|
Hmmm, I think they are marked as broken |
Contributor
They are marked as broken, indeed. I don't know why nixpkgs-review did not classify them as broken. |
Member
Author
|
Result of 4 packages marked as broken and skipped:
51 packages built:
|
Member
Author
|
(The above one is generated by nixpkgs-review 2.8.0) Are you interested in doing bisects right now since I have some $work to deal with and cannot do that fast 😿 ? Since things work fine 2 weeks ago in #221278 (I pasted a nixpkgs-review in the opening), I would probably blame the nixpkgs-review update, which happened a week ago in #222211. It sounds like using 2.8.0 with Mic92/nixpkgs-review@3193e60 backported (due to a 400 issue) things work fine. So we likely only need to bisect Mic92/nixpkgs-review@2.8.0...2.9.0. |
Contributor
|
Currently I have nixpkgs-review 2.9.0 on my system. But I am not interested in doing bisects now, as I am in hurry with other things. |
romildo
approved these changes
Mar 29, 2023
Member
Author
|
Did not bisect, probably Mic92/nixpkgs-review#315 is the reason, passing |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Notably contains crash fix(es) for glib 2.76
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)